-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Unskip install_large_prebuilt_rules_package
#192563
[Security Solution] Unskip install_large_prebuilt_rules_package
#192563
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6916[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/large_prebuilt_rules_package/trial_license_complete_tier/configs/ess.config.ts: 62/100 tests passed. |
5410688
to
716ba52
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6933[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/large_prebuilt_rules_package/trial_license_complete_tier/configs/ess.config.ts: 66/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6935[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/large_prebuilt_rules_package/trial_license_complete_tier/configs/ess.config.ts: 0/100 tests passed. |
716ba52
to
d8f27d2
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6936[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/large_prebuilt_rules_package/trial_license_complete_tier/configs/ess.config.ts: 57/100 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#6937[❌] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/large_prebuilt_rules_package/trial_license_complete_tier/configs/ess.config.ts: 0/100 tests passed. |
d8f27d2
to
a22e630
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6938[✅] x-pack/test/security_solution_api_integration/test_suites/detections_response/rules_management/prebuilt_rules/large_prebuilt_rules_package/trial_license_complete_tier/configs/ess.config.ts: 100/100 tests passed. |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Do you have an idea of the performance impact that refresh: wait_for
has? I guess it will slow down the install but curious to see if it's measurable
Pinging @elastic/fleet (Team:Fleet) |
install_large_prebuilt_rules_package
install_large_prebuilt_rules_package
Let me know if you think we need to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @maximpn |
…astic#192563) **Addresses:** elastic#192479 ## Summary This PR unskips `install_large_prebuilt_rules_package` FTR test. ## Details The flakiness is caused by chunked assets installation inside the Fleet plugin. Used no index refresh strategy leads to reading stale data in `PUT /api/detection_engine/rules/prepackaged` endpoint handler and returning arbitrary data. The problem was fixed by adding `refresh=wait_for` for the last assets chunk installation. ## Flaky test runner - 🟢 (100 runs) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6938 (cherry picked from commit b3baadd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ackage` (#192563) (#193091) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Unskip `install_large_prebuilt_rules_package` (#192563)](#192563) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maxim Palenov","email":"maxim.palenov@elastic.co"},"sourceCommit":{"committedDate":"2024-09-16T20:57:22Z","message":"[Security Solution] Unskip `install_large_prebuilt_rules_package` (#192563)\n\n**Addresses:** https://github.com/elastic/kibana/issues/192479\r\n\r\n## Summary\r\n\r\nThis PR unskips `install_large_prebuilt_rules_package` FTR test.\r\n\r\n## Details\r\n\r\nThe flakiness is caused by chunked assets installation inside the Fleet plugin. Used no index refresh strategy leads to reading stale data in `PUT /api/detection_engine/rules/prepackaged` endpoint handler and returning arbitrary data.\r\n\r\nThe problem was fixed by adding `refresh=wait_for` for the last assets chunk installation.\r\n\r\n## Flaky test runner\r\n\r\n- 🟢 (100 runs) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6938","sha":"b3baadd14ae0cc07e22d878bdd24861309a26426","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-failure-flaky","Team:Fleet","v9.0.0","Team:Detections and Resp","fixed","Team: SecuritySolution","Team:Detection Rule Management","v8.16.0"],"title":"[Security Solution] Unskip `install_large_prebuilt_rules_package`","number":192563,"url":"https://github.com/elastic/kibana/pull/192563","mergeCommit":{"message":"[Security Solution] Unskip `install_large_prebuilt_rules_package` (#192563)\n\n**Addresses:** https://github.com/elastic/kibana/issues/192479\r\n\r\n## Summary\r\n\r\nThis PR unskips `install_large_prebuilt_rules_package` FTR test.\r\n\r\n## Details\r\n\r\nThe flakiness is caused by chunked assets installation inside the Fleet plugin. Used no index refresh strategy leads to reading stale data in `PUT /api/detection_engine/rules/prepackaged` endpoint handler and returning arbitrary data.\r\n\r\nThe problem was fixed by adding `refresh=wait_for` for the last assets chunk installation.\r\n\r\n## Flaky test runner\r\n\r\n- 🟢 (100 runs) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6938","sha":"b3baadd14ae0cc07e22d878bdd24861309a26426"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192563","number":192563,"mergeCommit":{"message":"[Security Solution] Unskip `install_large_prebuilt_rules_package` (#192563)\n\n**Addresses:** https://github.com/elastic/kibana/issues/192479\r\n\r\n## Summary\r\n\r\nThis PR unskips `install_large_prebuilt_rules_package` FTR test.\r\n\r\n## Details\r\n\r\nThe flakiness is caused by chunked assets installation inside the Fleet plugin. Used no index refresh strategy leads to reading stale data in `PUT /api/detection_engine/rules/prepackaged` endpoint handler and returning arbitrary data.\r\n\r\nThe problem was fixed by adding `refresh=wait_for` for the last assets chunk installation.\r\n\r\n## Flaky test runner\r\n\r\n- 🟢 (100 runs) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6938","sha":"b3baadd14ae0cc07e22d878bdd24861309a26426"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Maxim Palenov <maxim.palenov@elastic.co>
Addresses: #192479
Summary
This PR unskips
install_large_prebuilt_rules_package
FTR test.Details
The flakiness is caused by chunked assets installation inside the Fleet plugin. Used no index refresh strategy leads to reading stale data in
PUT /api/detection_engine/rules/prepackaged
endpoint handler and returning arbitrary data.The problem was fixed by adding
refresh=wait_for
for the last assets chunk installation.Flaky test runner